Skip to content

Commit

Permalink
Update PKIDeployer.setup_system_cert() to reuse existing request
Browse files Browse the repository at this point in the history
  • Loading branch information
edewata committed Jan 15, 2024
1 parent 49e5fe9 commit fddf10d
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions base/server/python/pki/server/deployment/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3303,19 +3303,23 @@ def setup_system_cert(self, nssdb, subsystem, tag, system_cert, request):

logger.info('- key ID: %s', request.systemCert.keyID)

request.systemCert.request = self.create_cert_request(nssdb, tag, request)
logger.debug('- request: %s', request.systemCert.request)
csr_file = subsystem.csr_file(tag)
if os.path.exists(csr_file):
logger.info('Reusing %s cert request in %s', tag, csr_file)

system_cert['token'] = request.systemCert.token
system_cert['request'] = request.systemCert.request
else:
request.systemCert.request = self.create_cert_request(nssdb, tag, request)
logger.debug('- request: %s', request.systemCert.request)

system_cert['request'] = request.systemCert.request

logger.info('Storing cert request for %s', tag)
subsystem.store_system_cert_request(system_cert)
logger.info('Storing cert request for %s', tag)
subsystem.store_system_cert_request(system_cert)

if request.systemCert.type == 'remote':

if cert_info:
logger.info('Reusing existing %s cert in NSS database', tag)
logger.info('Reusing %s cert in NSS database', tag)
return

# Issue subordinate CA signing cert using remote CA signing cert.
Expand Down Expand Up @@ -3379,7 +3383,7 @@ def setup_system_cert(self, nssdb, subsystem, tag, system_cert, request):
self.import_cert_request(subsystem, tag, request)

if cert_info:
logger.info('Reusing existing %s cert in NSS database', tag)
logger.info('Reusing %s cert in NSS database', tag)

else:
system_cert['data'] = self.create_cert(subsystem, tag, request)
Expand Down

0 comments on commit fddf10d

Please sign in to comment.