Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HSM support for LWCA #4659

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Add HSM support for LWCA #4659

merged 1 commit into from
Jan 29, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 19, 2024

The CAEngine.createCA() has been modified to get the token name from LWCA's keyNickname. If the token name exists, it will use that token to create the private key and store the cert. Otherwise, it will use the internal token.

The CASigningUnit.init() has been modified to get the token name from name from LWCA's keyNickname. If the token name exists, it will use that token to load the cert and the private key, and for signing and verification. Otherwise, it will use the internal token.

The LWCA test with HSM has been modified to verify that the LWCA cert and key will be created in HSM instead of internal token.

Resolves: #2412

The CAEngine.createCA() has been modified to get the token
name from LWCA's keyNickname. If the token name exists,
it will use that token to create the private key and store
the cert. Otherwise, it will use the internal token.

The CASigningUnit.init() has been modified to get the token
name from name from LWCA's keyNickname. If the token name
exists, it will use that token to load the cert and the
private key, and for signing and verification. Otherwise, it
will use the internal token.

The LWCA test with HSM has been modified to verify that the
LWCA cert and key will be created in HSM instead of internal
token.

Resolves: dogtagpki#2412
@edewata edewata requested a review from fmarco76 January 19, 2024 16:39
Copy link

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jan 29, 2024

@fmarco76 Thanks!

@edewata edewata merged commit cd68b1b into dogtagpki:master Jan 29, 2024
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightweight CAs: HSM support
2 participants