Make CertRecordPagedList generic #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class `CertRecordPagedList` is renamed to `RecordPagedList` and made generic to be used with all type of entries available.
|
edewata
approved these changes
Jan 29, 2024
Comment on lines
120
to
123
| DBSearchResults sr = new DBSearchResults(registry, res); | ||
| while (sr.hasMoreElements()) { | ||
| entries.add((CertRecord) sr.nextElement()); | ||
| entries.add(contentClassType.cast(sr.nextElement())); | ||
| } |
There was a problem hiding this comment.
Suppose we can use generics in DBSearchResults as well, we might not need the contentClassType.
ArrayList<E> entries = new ArrayList<>();
DBSearchResults<E> sr = new DBSearchResults<>(registry, res);
entries.add(sr.nextElement());
There was a problem hiding this comment.
I tried this approach but eclipse and java was complaining because add() is expecting an object from class E. With generic you cannot do dynamic type cast either entries.add((E) sr.nextElement()). The option I have investigated are:
- suppressing all the possible warning
- creating a custom class handling the the runtime type using reflection
- provide the runtime type
I opted for the last one because it looks the cleaner and safer to implement but if we found better approaches we can always improve.
|
@edewata Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
CertRecordPagedListis renamed toRecordPagedListand made generic to be used with all type of entries available.