Fix pki-server instance-find #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pki-server instance-find has been updated to find instances existing on the system based on PKIServer.exists(). The PKIServer.exists() has also been updated to check whether the instance actually exists based on the <instance>/bin folder. It does not use the <instance> folder itself since there might be files (e.g. config files, logs) left in the folder after removing the instance. The test for installing CA with existing config has been updated to validate pki-server instance-* commands.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pki-server instance-findhas been updated to find instances existing on the system based onPKIServer.exists().The
PKIServer.exists()has also been updated to check whether the instance actually exists based on the<instance>/binfolder. It does not use the<instance>folder itself since there might be files (e.g. config files, logs) left in the folder after removing the instance.The test for installing CA with existing config has been updated to validate
pki-server instance-*commands.