-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated params in examples #4957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't see pki_ds_url being introduced in default.cfg. Add?
- I don't see where (default.cfg?)
pki_ds_ldap_port
andpki_ds_ldaps_port
are being introduced as deprecated. Add? (we ask people to look at default.cfg for "additional parameters" - are we sure no installation would expect both ports to be present?
The The The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The sample config files have been updated to use pki_ds_url instead of pki_ds_ldap_port and pki_ds_ldaps_port since those params have been deprecated since PKI 11.5 and will generate deprecation warnings if used.
|
@ladycfu Thanks! I had to return |
The sample config files have been updated to use
pki_ds_url
instead ofpki_ds_ldap_port
andpki_ds_ldaps_port
since those params have been deprecated since PKI 11.5 and will generate deprecation warnings if used.https://github.com/edewata/pki/blob/ci/base/server/etc/default.cfg#L88-L92
https://github.com/dogtagpki/pki/blob/master/docs/changes/v11.5.0/Server-Changes.adoc#add-pki_ds_url-parameter
https://github.com/dogtagpki/pki/blob/master/docs/manuals/man5/pki_default.cfg.5.md#internal-database-parameters