Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable certificate revocation check in NonBlockingSocketFactory #4968

Merged
merged 1 commit into from
Feb 26, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,18 +79,10 @@ public Socket connectSocket(Socket socket,
KeyManagerFactory kmf = KeyManagerFactory.getInstance("NssX509", "Mozilla-JSS");
KeyManager[] kms = kmf.getKeyManagers();

// Create JSSTrustManager since the default JSSNativeTrustManager
// does not support hostname validation and cert approval callback.
//
// JSSTrustManager currently does not support cert validation with
// OCSP and CRL.
//
// TODO: Fix JSSTrustManager to support OCSP and CRL, then replace
// DefaultSocketFactory with this class.

JSSTrustManager trustManager = new JSSTrustManager();
trustManager.setHostname(hostname);
trustManager.setCallback(connection.getCallback());
trustManager.setEnableCertRevokeVerify(true);

TrustManager[] tms = new TrustManager[] { trustManager };

Expand Down
Loading