Skip to content

fix: preserve reverse-loop parallax item styles#913

Open
dohooo wants to merge 1 commit intomainfrom
caspian/issue-899-parallax-reverse-loop-pr
Open

fix: preserve reverse-loop parallax item styles#913
dohooo wants to merge 1 commit intomainfrom
caspian/issue-899-parallax-reverse-loop-pr

Conversation

@dohooo
Copy link
Copy Markdown
Owner

@dohooo dohooo commented Mar 30, 2026

Summary

Minimal reproduction

  • loop={true}
  • mode="parallax"
  • start at defaultIndex={0}
  • swipe backward across the loop boundary

Before this change, the reverse-side item was missing from the first reverse-wrap ACTIVE frame, so its React-driven style/props arrived a tick late.

Verification

  • yarn test --runInBand src/components/issue-899-parallax-reverse-loop.test.tsx
  • yarn test --runInBand src/layouts/parallax.test.ts src/components/Carousel.test.tsx
  • yarn types

Closes #899

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 30, 2026

⚠️ No Changeset found

Latest commit: 627996a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 30, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-reanimated-carousel Ready Ready Preview, Comment Mar 30, 2026 2:26am

Request Review

@dosubot dosubot bot added the bug Something isn't working label Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.50%. Comparing base (fec99d7) to head (627996a).

Files with missing lines Patch % Lines
src/hooks/useVisibleRanges.tsx 96.55% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   84.32%   84.50%   +0.17%     
==========================================
  Files          37       37              
  Lines        1040     1052      +12     
  Branches      362      366       +4     
==========================================
+ Hits          877      889      +12     
  Misses         67       67              
  Partials       96       96              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loop={true} — Styles (backgroundColor, etc.) not applied to reverse-direction cloned items in parallax mode

1 participant