Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix React Examples #105

Closed
1 task done
satyambnsal opened this issue Jan 14, 2024 · 2 comments
Closed
1 task done

[Bug]: Fix React Examples #105

satyambnsal opened this issue Jan 14, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@satyambnsal
Copy link

Dojo.js Version

0.2.10

What happened?

DojoProvider usage in both react examples is incorrect. Also generate component script is using incorrect dojo-starter path.

What is the expected behavior?

Should provide world address as a first argument in DojoProvider

Steps to reproduce

Run any of the react example

Trace

No response

Is there an existing issue for this?

  • I have searched the existing issues and verified no issue exits for this problem.
@rsodre
Copy link
Contributor

rsodre commented Jan 16, 2024

Trying to update my games to the new examples, but will give up for now due to inconsistencies in the examples
Some more notes on the react-app example...

  • still importing packages version 0.2.10, instead of the latest 0.3.3
  • there's a new src/dojo/generated/ folder but no task to build it. How do we call the new generator script?
  • thecreate-components task will not work because of the new folder structure (missing /generated/)
  • shouldn't all graphql stuff be removed by now?

@ponderingdemocritus

@ponderingdemocritus
Copy link
Contributor

fixed in #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants