Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react and react-phaser example scripts and add instructions #104

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Fix react and react-phaser example scripts and add instructions #104

merged 6 commits into from
Jan 16, 2024

Conversation

satyambnsal
Copy link

@satyambnsal satyambnsal commented Jan 14, 2024 •
edited
Loading

Closes #

#105
#103

Introduced changes

  • Fix DojoProvider usage in React examples
  • Fix generate component script
  • Fix build-phaser script
  • Add React example instructions
  • Fix react package build issue

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Add a dedicated CI job for new examples
  • Performed self-review of the code

@satyambnsal satyambnsal changed the title [WIP] Fix react and react-phaser example scripts and add instructions Fix react and react-phaser example scripts and add instructions Jan 14, 2024
@satyambnsal satyambnsal marked this pull request as ready for review January 14, 2024 11:08
@ponderingdemocritus ponderingdemocritus merged commit c5ef6da into dojoengine:main Jan 16, 2024
1 of 2 checks passed
@ponderingdemocritus ponderingdemocritus mentioned this pull request Jan 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponderingdemocritus ponderingdemocritus Awaiting requested review from ponderingdemocritus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satyambnsal @ponderingdemocritus