Open
Conversation
Report for GMSJ01 (ccd2b79 - 2f3f821)📉 Matched code: 27.03% (-0.01%, -484 bytes) ✅ 26 new matches
🥀 9 broken matches
📈 25 improvements in unmatched items
📉 33 regressions in unmatched items
...and 3 more regressions in unmatched items |
Mrkol
reviewed
Feb 28, 2026
src/Player/MarioDraw.cpp
Outdated
| anmTexNoAnm[i][j].setAnmTexPattern(anmTexPattern[i]); | ||
| } | ||
| i++; | ||
| } while (i < 0x18); |
Collaborator
There was a problem hiding this comment.
Should definitely be a regular for loop
TheAzack9
commented
Mar 2, 2026
include/M3DUtil/M3UModelMario.hpp
Outdated
| public: | ||
| /* 0x20 */ M3UModelCommonMario* unk20; | ||
| /* 0x24 */ M3UMarioMtxCalcSetInfo* unk24; | ||
| // /* 0x28 */ J3DMtxCalcSoftimage unk28; |
Contributor
Author
There was a problem hiding this comment.
I am going to take a second look at M3UModelMario for this, but this was causing some of the broken matches bcs of the #include <JSystem/J3D/J3DGraphAnimator/J3DJoint.hpp>. It is not in use currently so i just commented it out, but initModel in TMario refers to this and adding this makes it match.
I assume we possibly need the stuff with precompiled headers 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more fuzzy than i wished for, but i struggled with MarioDraw lmao, so much data...