Skip to content

First pass at MapWire#88

Merged
Mrkol merged 67 commits intodoldecomp:mainfrom
lingomaniac88:mapwire
Mar 2, 2026
Merged

First pass at MapWire#88
Mrkol merged 67 commits intodoldecomp:mainfrom
lingomaniac88:mapwire

Conversation

@lingomaniac88
Copy link
Contributor

This is a first pass at MapWire. A couple of methods still need matching work, but they're human-readable and should be equivalent to the target.

@decomp-dev
Copy link

decomp-dev bot commented Mar 1, 2026

Report for GMSJ01 (4ad32d9 - 9d7dc9c)

📈 Matched code: 27.05% (+0.01%, +528 bytes)
📈 Matched data: 29.55% (+0.02%, +116 bytes)

✅ 9 new matches
Unit Item Bytes Before After
mario/Map/MapWire JGeometry::TRotation3<JGeometry::TMatrix33<JGeometry::SMatrix33C<float>>>::setEular(short, short, short) +168 0.00% 100.00%
mario/Map/MapWire TMapWire::getPointPosAtHanged(float, JGeometry::TVec3<float>*) const +161 2.44% 100.00%
mario/Map/MapWire TMapWire::calcViewAndDBEntry() +76 5.00% 100.00%
mario/Map/MapWire .sdata2 +65 10.53% 100.00%
mario/Map/MapWire TMapWire::getPointPowerAtReleased(float) const +56 6.67% 100.00%
mario/Map/MapWire .sdata +40 0.00% 100.00%
mario/Map/MapWire TMapWirePoint::TMapWirePoint() +36 10.00% 100.00%
mario/Map/MapWire JGeometry::TVec3<float>::set<float>(float, float, float) +16 0.00% 100.00%
mario/Map/MapWire .ctors +4 0.00% 100.00%
📈 11 improvements in unmatched items
Unit Item Bytes Before After
mario/Map/MapWire TMapWire::init(const TCubeGeneralInfo*) +947 0.24% 58.19%
mario/Map/MapWire __sinit_MapWire_cpp +712 0.00% 93.19%
mario/Map/MapWire TMapWire::drawLower() const +449 0.76% 86.26%
mario/Map/MapWire TMapWire::setFootPointsAtHanged(float(*)[4]) +321 0.60% 48.80%
mario/Map/MapWire TMapWire::move() +320 0.62% 50.63%
mario/Map/MapWire TMapWire::getPointPosOnWire(float, JGeometry::TVec3<float>*) const +300 1.00% 76.00%
mario/Map/MapWire TMapWire::release() +292 0.37% 27.11%
mario/Map/MapWire TMapWire::drawUpper() const +237 1.32% 78.95%
mario/Map/MapWire .bss +178 0.00% 96.77%
mario/Map/MapWire TMapWire::getPosInWire(const JGeometry::TVec3<float>&) const +161 0.97% 39.81%
mario/Map/MapWire .rodata +93 0.00% 83.33%

@Mrkol Mrkol merged commit ccd2b79 into doldecomp:main Mar 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants