Web: add dolt login for local dolt server #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbantle22
approved these changes
Apr 15, 2025
web/main/doltServer.ts
Outdated
| event.sender.send("login-started", requestId); | ||
|
|
||
| let timedOut = false; | ||
| const timeoutDuration = 5 * 60 * 1000; // 5 minutes |
There was a problem hiding this comment.
This seems like too long maybe? 1 minute might be better?
web/renderer/gen/graphql-types.tsx
Outdated
| @@ -245,6 +245,7 @@ export type Mutation = { | |||
| deleteBranch: Scalars['Boolean']['output']; | |||
| deleteRemote: Scalars['Boolean']['output']; | |||
| deleteTag: Scalars['Boolean']['output']; | |||
| doltLogin: Scalars['Boolean']['output']; | |||
There was a problem hiding this comment.
Where are the graphql changes for these?
| } finally { | ||
| setPending(false); | ||
| // Cleanup ID reference | ||
| if (requestId) setCancelId(null); |
There was a problem hiding this comment.
Can this go at the end of the try block instead? Then you don't need to reassign the requestId variable
Comment on lines
90
to
93
| {success.active ? ( | ||
| <div className={css.successMsg}> | ||
| Logged in as {loggedInUser?.username} ({loggedInUser?.email}) | ||
| </div> |
There was a problem hiding this comment.
Should maybe only show this if loggedInUser is defined too
| className={css.loginButton} | ||
| disabled={pending} | ||
| > | ||
| {pending ? "Login..." : "Dolt Login"} |
There was a problem hiding this comment.
Suggested change
| {pending ? "Login..." : "Dolt Login"} | |
| {pending ? "Logging in..." : "Dolt Login"} |
|
|
||
| return ( | ||
| <QueryHandler | ||
| result={{ ...res, data: res.data }} |
There was a problem hiding this comment.
Suggested change
| result={{ ...res, data: res.data }} | |
| result={res} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dolt login button in remotes tab:
after adding credentials on dolthub: