Add support for mutual TLS authentication #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbantle22
reviewed
Nov 25, 2025
Collaborator
tbantle22
left a comment
tbantle22
left a comment
There was a problem hiding this comment.
Overall looks good, a few comments here and UI feedback in discord
Comment on lines
+29
to
+33
| certificateAuthority?: string; | ||
|
|
||
| clientCert?: string; | ||
|
|
||
| clientKey?: string; |
Collaborator
There was a problem hiding this comment.
Seems like this would be better as one type like mtlsAuth?: MutualTlsAuth and then each of these fields in MutualTlsAuth should be required
Comment on lines
+30
to
+37
| @Field({ nullable: true }) | ||
| certificateAuthority?: string; | ||
|
|
||
| @Field({ nullable: true }) | ||
| clientCert?: string; | ||
|
|
||
| @Field({ nullable: true }) | ||
| clientKey?: string; |
Collaborator
There was a problem hiding this comment.
Same here and in database.resolver.ts
| import { SetApolloErrorType } from "@lib/errors/types"; | ||
| import { Dispatch, SyntheticEvent } from "react"; | ||
|
|
||
| export type AuthType = "none" | "ssl" | "mtls"; |
Collaborator
There was a problem hiding this comment.
Better to use an enum here so you don't have to type cast the string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #702
Adds this popup to the connection tab:
Then, authenticates the user via mutual TLS.