-
Notifications
You must be signed in to change notification settings - Fork 246
updates process_reports to respect newly added prettify_json option #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates process_reports to respect newly added prettify_json option #617
Conversation
|
Why include a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 58.39% 58.29% -0.10%
==========================================
Files 12 11 -1
Lines 1620 1748 +128
==========================================
+ Hits 946 1019 +73
- Misses 674 729 +55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I was thinking it would beneficial to offer an explicit option for CLI readability for those who may be automating this via systemd service / Docker image creation. |
|
Let's remove that option to avoid cluttering the CLI with an option that doesn't do anything, because the fact that the JSON is pettified by default is implied by the existence of |
Sounds good. I have removed the option. Let me know what you think. |
|
Please fix the test failures |
I want to facilitate the parsing of JSON logs directly with Grafana Alloy + Loki. To do this, it would be beneficial to output the JSON logs as a single line to be then parsed within Grafana. Currently, because the report is "prettified" it treats each new line of the log, as a different log entry within grafana. Collapsing the log to a single line, will allow it to be parsed properly within Grafana.