Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚Move tests to net7 to fix build #2672

Closed
wants to merge 2 commits into from

Conversation

schnerring
Copy link

@schnerring schnerring commented Jun 16, 2023

@jerryk414
Copy link

@schnerring Is there a timeline or any blockers on merging this in along with #2671?

Really looking forward to being able to use discriminators in .NET 7 without having to add duplicate code.

@schnerring
Copy link
Author

Since creating the PR, I haven't looked at this again. I guess it would be good timing to sync this with the upcoming .NET 8 changes? But I haven't checked if this is tracked anywhere.

@martincostello
Copy link
Collaborator

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI.

From looking at the description only, some parts of this will have been addressed by #2775.

@martincostello
Copy link
Collaborator

Thanks for the contribution. The TFM updates are covered by the changes in #2799 to add support for .NET 8, and the other changes look like they were covered with #2775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants