Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native AoT support for ReDoc #3088

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

martincostello
Copy link
Collaborator

- Add support for using the ReDoc middleware in native AoT applications.
- Add missing test coverage for ReDoc extensions.
- Fix some code analysis suggestions.
- Fix native AoT test app exception on start-up (see domaindrivendev#2951).
@martincostello martincostello added the aot Relates to native AoT support label Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (9fa161b) to head (5230198).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...rc/Swashbuckle.AspNetCore.ReDoc/ReDocMiddleware.cs 88.88% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3088      +/-   ##
==========================================
+ Coverage   90.50%   91.44%   +0.93%     
==========================================
  Files          76       76              
  Lines        3118     3121       +3     
  Branches      516      519       +3     
==========================================
+ Hits         2822     2854      +32     
+ Misses        296      267      -29     
Flag Coverage Δ
Linux 91.44% <91.66%> (+0.93%) ⬆️
Windows 91.44% <91.66%> (+0.93%) ⬆️
macOS 91.44% <91.66%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mesMess mesMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional compilation to cover various NET runtimes
Consolidation of some partial classes
Support for ReDoc in AOT apps

@mesMess mesMess merged commit 0abed87 into domaindrivendev:master Oct 15, 2024
9 checks passed
@martincostello martincostello deleted the redoc-native-aot branch October 15, 2024 06:32
@martincostello martincostello added this to the v6.9.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aot Relates to native AoT support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants