Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some nugets #3143

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Conversation

Saibamen
Copy link
Contributor

Update some nuget packages

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (be0090d) to head (c80c61f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3143      +/-   ##
==========================================
- Coverage   84.81%   82.11%   -2.71%     
==========================================
  Files          79       76       -3     
  Lines        3279     3125     -154     
  Branches      555      526      -29     
==========================================
- Hits         2781     2566     -215     
- Misses        498      559      +61     
Flag Coverage Δ
Linux 82.11% <ø> (ø)
Windows ?
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Saibamen and others added 2 commits November 14, 2024 10:58
Co-authored-by: Martin Costello <martin@martincostello.com>
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
Directory.Packages.props Outdated Show resolved Hide resolved
@martincostello
Copy link
Collaborator

LGTM pending the question about the Autofac upgrade.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Nov 14, 2024
@Saibamen
Copy link
Contributor Author

@martincostello: I updated xUnit package to 2.9.2, but in Swashbuckle.AspNetCore.ApiTesting.Xunit project it is 2.4.1. Should I delete VersionOverride tag?

<PackageReference Include="xunit" VersionOverride="2.4.1" />

@martincostello
Copy link
Collaborator

No, leave all the version overrides alone - otherwise a future release of our xunit package would force an upgrade on people that they might not otherwise want.

@martincostello
Copy link
Collaborator

Thanks for being our human dependabot 🤖 😄

@martincostello martincostello merged commit e759f46 into domaindrivendev:master Nov 14, 2024
9 checks passed
@Saibamen Saibamen deleted the nuget_update branch November 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants