fix test method with category

don-bigdad · Jan 24, 2024 · 1769139 · 1769139
1 parent 70aa337
commit 1769139
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/test/java/com/example/springbootbookshop/controller/BookControllerTest.java b/src/test/java/com/example/springbootbookshop/controller/BookControllerTest.java
@@ -44,8 +44,7 @@ public class BookControllerTest {
     private ObjectMapper objectMapper;
 
     @BeforeAll
-    static void beforeAll(@Autowired WebApplicationContext applicationContext,
-                          @Autowired DataSource dataSource) throws SQLException {
+    static void beforeAll(@Autowired WebApplicationContext applicationContext) {
         mockMvc = MockMvcBuilders.webAppContextSetup(applicationContext)
                 .apply(springSecurity())
                 .build();

diff --git a/src/test/java/com/example/springbootbookshop/controller/CategoryControllerTest.java b/src/test/java/com/example/springbootbookshop/controller/CategoryControllerTest.java
@@ -181,7 +181,8 @@ void updateBookByIdAssertSuccess() throws Exception {
 
     @Test
     @DisplayName("Get all books by category id")
-    @Sql(scripts = {"classpath:database/books/insert-new-books.sql",
+    @Sql(scripts = {"classpath:database/books/clear-books-db.sql",
+            "classpath:database/books/insert-new-books.sql",
             "classpath:database/books-categories/insert-books-categories.sql"},
             executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD)
     @Sql(scripts = "classpath:database/books-categories/clear-book-category.sql",
@@ -194,8 +195,8 @@ void getAllBooksByCategoryAssertSuccess() throws Exception {
                 .andReturn();
         List<BookDtoWithoutCategoryIds> bookDtoWithoutCategoryIds = objectMapper.readValue(
                 result.getResponse().getContentAsString(), new TypeReference<>() {});
-        assertEquals(2, bookDtoWithoutCategoryIds.size());
-        assertEquals("Book 5", bookDtoWithoutCategoryIds.get(1).title());
+        assertEquals(1, bookDtoWithoutCategoryIds.size());
+        assertEquals("Book 5", bookDtoWithoutCategoryIds.get(0).title());
     }
 
     private CategoryDto getExpectDto() {

diff --git a/src/test/resources/database/books-categories/insert-books-categories.sql b/src/test/resources/database/books-categories/insert-books-categories.sql
@@ -1,8 +1,5 @@
 INSERT INTO books_categories (book_id, category_id)
 VALUES
-    (1, 1),
-    (2, 2),
-    (3, 3),
     (4, 1),
     (5, 2),
     (6, 3);