feat(objects): add option to drop undefined keys instead of converting to nil.#677
Open
cognigy-fabian wants to merge 5 commits intodop251:masterfrom
Open
feat(objects): add option to drop undefined keys instead of converting to nil.#677cognigy-fabian wants to merge 5 commits intodop251:masterfrom
cognigy-fabian wants to merge 5 commits intodop251:masterfrom
Conversation
…g to nil.
We have the following code that constructs `undefined` keys inside an object and calls some Go binding:
```js
const input = { foo: "bar" };
const { foo, undefinedKey } = input;
const newInput = { foo, undefinedKey };
actions.output(newInput);
```
Currently this exports the input to `{"foo": "bar", "undefinedKey": nil}` in Go.
With the new VM option it would export to `{"foo": "bar"}`.
kcog
approved these changes
Sep 3, 2025
Owner
|
I don't see a case for it, tbh... Both JS and Go distinguish between a property (or a map element) not present and being undefined (or nil). If you do not want the property to appear in the exported value you can delete it before exporting. It's not a job for goja to do data transformations during export. |
…aleDateString, toLocaleTimeString AB#115818
fix(date): missing timeZone option handling for toLocaleString, toLocaleDateString, toLocaleTimeString
fix(date): fix missing nil check for timeZone handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the following code that constructs
undefinedkeys inside an object and calls some Go binding:Currently this exports the input to
{"foo": "bar", "undefinedKey": nil}in Go.With the new VM option it would export to
{"foo": "bar"}.