Fix stack overflow when converting arrays with circular references to primitives#695
Merged
dop251 merged 2 commits intodop251:masterfrom Jan 6, 2026
Merged
Fix stack overflow when converting arrays with circular references to primitives#695dop251 merged 2 commits intodop251:masterfrom
dop251 merged 2 commits intodop251:masterfrom
Conversation
dop251
requested changes
Jan 5, 2026
Owner
dop251
left a comment
There was a problem hiding this comment.
Thanks for submitting thiis! I've added a few comments.
Contributor
Author
|
@dop251 has already submitted a modification, please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack overflow occurs in goja when attempting to convert an object containing a circular reference to a primitive value (via
toPrimitive,toString,toNumeric, etc.).Minimal Reproduction
Environment