-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for dotnet nunit #206
Conversation
Closing this Because test were not successful. |
The failure of the check seems to be unrelated to tests not being successful? |
Thanks @simensan for the PR. You are right. This is the same situation as we have in #208. One of the check run fails due to permission issues. This happens when PR is from forked repo. I have to rework the workflow. Anyway I see there are some other modification apart from the new NUnit parser. I will review it in the evening after my work day. |
Hi @dorny , I experienced the same message here https://github.com/kubernetes/ingress-nginx/actions/runs/3610316594/jobs/6084083732 Any comments if they are related and a issue pending resolution or if I have a problem in my config
I don't have a "artifact" field because my attempts to specify a regex pattern are failing for the "artifact" field. Example I tried |
Sorry guys, I was again quite busy recently and forgot about it. I hope I will make it tomorrow or over the weekend. |
So I've finally looked into this. It will need some adjustments but I'm definitely for adding NUnit support.
|
If the #225 does not address the concerns reported here, we can build upon it in the next release. |
Added support for NUnit 3.0 result xml, which is what Unity Tes Runner produces.
Any feedback is appreciated!