Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added configurable permission for creating folders #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added configurable permission for creating folders #21

wants to merge 1 commit into from

Conversation

Olicek
Copy link
Contributor

@Olicek Olicek commented Feb 27, 2015

Based on this discussion: #20

webimages:
    umask: 0777

vojtech-dobes
vojtech-dobes reviewed Feb 27, 2015
View reviewed changes
src/Extension.php
@@ -35,6 +36,7 @@ public function loadConfiguration()
$generator = $container->addDefinition($this->prefix('generator'))
->setClass('DotBlue\WebImages\Generator', [
$config['wwwDir'],
$config['umask']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma at the end of line please

@vysinsky
Copy link
Collaborator

Now please fixup it to only one commit:

git rebase HEAD~4 -i
Change 'pick' in 2nd to 4th commit to 'fixup' and save the change
git push -f

Edit: only the first commit should be here in the end

@Olicek
Copy link
Contributor Author

Olicek commented Feb 27, 2015

Thanks a lot 👍! This is first time, i fixed up my mess in commits through this way

@vysinsky
Copy link
Collaborator

You're welcome!

vojtech-dobes
vojtech-dobes reviewed Mar 4, 2015
View reviewed changes
examples/config.neon
@@ -2,6 +2,7 @@ extensions:
webimages: DotBlue\WebImages\Extension

webimages:
umask: 0777 # default FALSE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this? I don't want this in example configuration. But mention in readme would be nice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finaly done :-)

@Olicek Olicek mentioned this pull request Jul 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Olicek @vysinsky @vojtech-dobes