Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run AppendToIgnoreService only on new #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/services/build-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import axios, {AxiosRequestConfig} from 'axios'
import {vars} from '../vars'
import {writeFileSync} from 'fs'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'
import {LoginService} from '../services/login-service'
Expand Down Expand Up @@ -33,8 +32,6 @@ class BuildService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down
3 changes: 0 additions & 3 deletions src/services/keys-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import chalk from 'chalk'
import axios, {AxiosRequestConfig} from 'axios'
import {vars} from '../vars'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'
import {LoginService} from '../services/login-service'
Expand Down Expand Up @@ -35,8 +34,6 @@ class KeysService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down
4 changes: 0 additions & 4 deletions src/services/local/build-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import chalk from 'chalk'
import {vars} from '../../vars'
import {writeFileSync, readFileSync, readdirSync} from 'fs'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../../services/append-to-ignore-service'
import {LogService} from '../../services/log-service'

interface LocalBuildServiceAttrs {
Expand All @@ -23,9 +22,6 @@ class LocalBuildService {

async run(): Promise<void> {
this.log.deprecated()

new AppendToIgnoreService().run()

const buildMsg = 'Building .env.vault from files on your machine'

CliUx.ux.action.start(`${chalk.dim(this.log.pretextLocal)}${buildMsg}`)
Expand Down
3 changes: 0 additions & 3 deletions src/services/local/keys-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import chalk from 'chalk'
import * as dotenv from 'dotenv'
import {vars} from '../../vars'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../../services/append-to-ignore-service'
import {LogService} from '../../services/log-service'
import {AbortService} from '../../services/abort-service'

Expand All @@ -26,8 +25,6 @@ class LocalKeysService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvKeys) {
this.abort.missingEnvKeys()
}
Expand Down
3 changes: 0 additions & 3 deletions src/services/login-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import axios, {AxiosRequestConfig} from 'axios'
import {existsSync, writeFileSync} from 'fs'
import {vars} from '../vars'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'

Expand Down Expand Up @@ -37,8 +36,6 @@ class LoginService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down
3 changes: 0 additions & 3 deletions src/services/pull-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import axios, {AxiosRequestConfig, AxiosResponse} from 'axios'
import {vars} from '../vars'
import {existsSync, renameSync, writeFileSync} from 'fs'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'
import {LoginService} from '../services/login-service'
Expand Down Expand Up @@ -39,8 +38,6 @@ class PullService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down
3 changes: 0 additions & 3 deletions src/services/push-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import axios, {AxiosRequestConfig} from 'axios'
import {vars} from '../vars'
import {existsSync, readFileSync, writeFileSync} from 'fs'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'
import {LoginService} from '../services/login-service'
Expand Down Expand Up @@ -39,8 +38,6 @@ class PushService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down
3 changes: 0 additions & 3 deletions src/services/versions-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import chalk from 'chalk'
import axios, {AxiosRequestConfig} from 'axios'
import {vars} from '../vars'
import {CliUx} from '@oclif/core'
import {AppendToIgnoreService} from '../services/append-to-ignore-service'
import {LogService} from '../services/log-service'
import {AbortService} from '../services/abort-service'
import {LoginService} from '../services/login-service'
Expand Down Expand Up @@ -35,8 +34,6 @@ class VersionsService {
}

async run(): Promise<void> {
new AppendToIgnoreService().run()

if (vars.missingEnvVault) {
this.abort.missingEnvVault()
}
Expand Down