Adds WithCaFile TlsOption to validate the connection with X509ChainPolicy.CustomRootTrust #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridomin
commented
Sep 23, 2023
| caCerts.ImportFromPemFile(caFile); | ||
| cvArgs.Chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust; | ||
| cvArgs.Chain.ChainPolicy.CustomTrustStore.AddRange(caCerts); | ||
| cvArgs.Chain.ChainPolicy.RevocationMode = X509RevocationMode.NoCheck; |
There was a problem hiding this comment.
private CAs are very likely to do not offer revocation endpoints.
ridomin
commented
Sep 23, 2023
|
|
||
| public MqttClientTlsOptionsBuilder WithCaFile(string caFile) | ||
| { | ||
| if (_tlsOptions.CertificateValidationHandler != null) |
There was a problem hiding this comment.
WithCaFile needs to configure the CertificateValidationHandler, if it was manually assigned this throws an exception.
ridomin
changed the title
|
.. apologies for the 4 commits, ready to review now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most MQTT clients from Paho (python, Java, GO) and even mosquitto-clients, allow to specify a
CaFileto connect to TLS endpoints protected with certificates issued by a private CA.A good example is
test.mosquitto.org:8883that requires https://test.mosquitto.org/ssl/mosquitto.org.crt to validate the server connectionDetails
CaFileoption to TlsOptionsWithCaFile(string caFile)to TlsOptionsBuilderCertificateValidationHandler cannot be set within
WithCaFileto avoid overriding the handler.Not use sure if the
#IF DEFScan be optimized to other platforms, since the custom chain validator was added in .NET 5, but targeting .NET6 since .NET5 is already out of support.