-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Cancellation Source for KeepAlive Messages #2129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment.
@chkr1011 Thank you for reviewing and improving the PR. |
@chkr1011 We are currently using v4.3.6 in our application and rely on the ManagedMqttClient as of now. |
I will create a port for version 4 soon. |
@chkr1011 Have you had any time for the port yet. Would really appreciate it. (I can also see why it's not a high priority ;)) |
@Erw1nT High priority does not mean it will be done tomorrow. For a project which is maintained by people in their free time, it means it is only one of the first things which is done as soon as the developers have some free time to work on it ;-) A new PR is here: #2144 |
@chkr1011 It does work as expected now. Thank you for your support. |
I found out that the issue found in #2108 likely comes due to the fact that the wrong duration is used for checking the keep alive interval.
In this test setup i connect to a public broker and use the approach described in #2108 to see if it is triggered within time.
https://github.com/Erw1nT/MqttKeepAlive/blob/master/Program.cs
Only when this line is added, the connection-changed/disconnected event is fired in time.