-
Notifications
You must be signed in to change notification settings - Fork 63
Stable Updates 20251124 #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
18
commits into
main
Choose a base branch
from
copilot/stable-updates-20251124
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stable Updates 20251124 #1320
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7523bc7
Initial plan
Copilot 4fd5cac
Update config.json with latest Maven versions and regenerate manifests
Copilot 46d379f
Add new navigationevent packages to config.json
Copilot f0d9d0e
Fix datastore-preferences-core-android to be built as a package
Copilot 6e98c8e
Add PublicAPI files for new packages
Copilot e501588
Update namespace file and PublicAPI changes
sheiksyedm 2aa0524
Fix DataStore serializer interface implementation
sheiksyedm 5d75d3e
Fix DataStore serializer type casting issues
sheiksyedm eb316d8
Fix DataStore JVM PreferencesFileSerializer with metadata
sheiksyedm f9195ac
Mark datastore-preferences-core-jvm as dependency-only
sheiksyedm 1a408c9
Complete DataStore fixes - remove duplicate classes from JVM
sheiksyedm 5feb043
Revert class removal - both packages must ship with all types
sheiksyedm 3c75507
Update PublicAPI for JVM PreferencesFileSerializer
sheiksyedm 3d93c29
Mark datastore-preferences-core-jvm as dependency-only to resolve CS0433
sheiksyedm 17cd87e
Fix CS0433 by renaming JVM DataStore namespace
sheiksyedm 9300c7e
Update published-namespaces.txt
sheiksyedm e628145
Fix published-namespaces.txt - restore Firebase/GMS namespaces
sheiksyedm a61e915
Update PublicAPI files for Tink and Firebase Perf
sheiksyedm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...roidx.datastore/datastore-preferences-core-android/Additions/PreferencesFileSerializer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| namespace AndroidX.DataStore.Preferences.Core; | ||
|
|
||
| public partial class PreferencesFileSerializer | ||
| { | ||
| global::Java.Lang.Object? global::AndroidX.DataStore.Core.ISerializer.DefaultValue => DefaultValue; | ||
|
|
||
| global::Java.Lang.Object? global::AndroidX.DataStore.Core.ISerializer.WriteTo(global::Java.Lang.Object? t, global::System.IO.Stream output, global::Kotlin.Coroutines.IContinuation p2) | ||
| { | ||
| return WriteTo((global::AndroidX.DataStore.Preferences.Core.Preferences?)t, output, p2); | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
.../androidx.datastore/datastore-preferences-core-android/Additions/PreferencesSerializer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| namespace AndroidX.DataStore.Preferences.Core; | ||
|
|
||
| public partial class PreferencesSerializer | ||
| { | ||
| global::Java.Lang.Object? global::AndroidX.DataStore.Core.OkIO.IOkioSerializer.DefaultValue => DefaultValue; | ||
|
|
||
| global::Java.Lang.Object? global::AndroidX.DataStore.Core.OkIO.IOkioSerializer.WriteTo(global::Java.Lang.Object? t, global::Square.OkIO.IBufferedSink sink, global::Kotlin.Coroutines.IContinuation p2) | ||
| { | ||
| return WriteTo((global::AndroidX.DataStore.Preferences.Core.Preferences?)t, sink, p2); | ||
| } | ||
| } |
1 change: 1 addition & 0 deletions
1
source/androidx.datastore/datastore-preferences-core-android/PublicAPI/PublicAPI.Shipped.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| #nullable enable |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you need to commit all changes to
PublicApi*.txtfilesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created initial PublicAPI files for all new packages in commit 6e98c8e. The CI build will populate these files with the actual API surface area once the packages are built.