Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump external/xamarin-android-tools from 36e574c to ac8d0ee #9817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 21, 2025

Bumps external/xamarin-android-tools from 36e574c to ac8d0ee.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from jonpryor as a code owner February 21, 2025 02:11
@dependabot dependabot bot added dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code labels Feb 21, 2025
@jonpryor
Copy link
Member

@dellis1972, @pjcollins: any idea why this PR is failing? The immediate cause is thatXamarin.Android.Build.Debugging.Tasks.dll can't be loaded:

  1:7>Target "_ResolveXamarinAndroidTools" in file "D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Common.Debugging.targets" from project "D:\a\_work\1\a\TestRelease\02-21_02.32.54\temp\ConvertCustomView\MyApp\MyApp.csproj" (target "AndroidPrepareForBuild" depends on it):
       Assembly loaded during TaskRun: Xamarin.Android.Build.Debugging.Tasks, Version=13.2.99.178, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (location: D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Build.Debugging.Tasks.dll, MVID: 06023889-8511-4017-a3bd-fb457402d42a, AssemblyLoadContext: MSBuild plugin D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Build.Debugging.Tasks.dll)

…but why can't Xamarin.Android.Build.Debugging.Tasks.dll be loaded?

Nothing in the diff looks at all relevant…

@jonpryor
Copy link
Member

@dependabot rebase

Bumps [external/xamarin-android-tools](https://github.com/dotnet/android-tools) from `36e574c` to `ac8d0ee`.
- [Commits](dotnet/android-tools@36e574c...ac8d0ee)

---
updated-dependencies:
- dependency-name: external/xamarin-android-tools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/submodules/external/xamarin-android-tools-ac8d0ee branch from e705b08 to 846a203 Compare February 21, 2025 18:51
@pjcollins
Copy link
Member

@dellis1972, @pjcollins: any idea why this PR is failing? The immediate cause is thatXamarin.Android.Build.Debugging.Tasks.dll can't be loaded:

  1:7>Target "_ResolveXamarinAndroidTools" in file "D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Common.Debugging.targets" from project "D:\a\_work\1\a\TestRelease\02-21_02.32.54\temp\ConvertCustomView\MyApp\MyApp.csproj" (target "AndroidPrepareForBuild" depends on it):
       Assembly loaded during TaskRun: Xamarin.Android.Build.Debugging.Tasks, Version=13.2.99.178, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (location: D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Build.Debugging.Tasks.dll, MVID: 06023889-8511-4017-a3bd-fb457402d42a, AssemblyLoadContext: MSBuild plugin D:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\35.99.0-ci.xamarin-android-tools-ac8d0ee.178\tools\Xamarin.Android.Build.Debugging.Tasks.dll)

…but why can't Xamarin.Android.Build.Debugging.Tasks.dll be loaded?

Nothing in the diff looks at all relevant…

I've seen this a few times after moving androidtools into android-platform-support , it's possible some assembly versioning logic was messed up or not carried over correctly? I handled this recently by making sure to bump dotnet/android-tools and android-platform-support -> dotnet/android-tools simultaneously. I set up https://devdiv.visualstudio.com/DevDiv/_git/android-platform-support/pullrequest/612998 for that and we can update the android-platform-support ref here once that is in.

Will still need to spend some time figuring out why this has been happening since the move though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants