Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspire Schema missing Dockerfile buildArgs spec #4864

Closed
1 task done
JonathanGiles opened this issue Jul 11, 2024 · 2 comments · Fixed by #5643
Closed
1 task done

Aspire Schema missing Dockerfile buildArgs spec #4864

JonathanGiles opened this issue Jul 11, 2024 · 2 comments · Fixed by #5643
Assignees
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone

Comments

@JonathanGiles
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Recently support for Dockerfile buildArgs was added in this PR, but it seems like the latest schema (or the latest published schema) does not yet state that buildArgs is valid configuration on a dockerfile.v0.

Expected Behavior

I would expect that given a valid buildArgs, such as that below, my IDE should not fail the json I am writing due to the schema validation failing. Example buildArgs that I expect to work:

  "buildArgs" : {
    "BASE_IMAGE" : "${storage-explorer-image.image}"
  }

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version info

No response

Anything else?

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jul 11, 2024
@davidfowl davidfowl added this to the 9.0 milestone Sep 7, 2024
@mitchdenny
Copy link
Member

Ah thanks for spotting this. We'll get this added into our version of the schema and update the test coverage. I'll also get it uploaded to schemastore.

@mitchdenny
Copy link
Member

@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants