Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildArgs for dockerfile.v0 schema tests. #5643

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Sep 10, 2024

Description

We were missing some schema for dockerfile.v0 and test cases for build args in both dockerfile.v0 and container.v1. Once this merges in the schema needs to be published to schema store as well.

Fixes #4864

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny added this to the 9.0 milestone Sep 10, 2024
@mitchdenny mitchdenny self-assigned this Sep 10, 2024
@mitchdenny mitchdenny added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 10, 2024
@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny merged commit 0bf9b0c into main Sep 12, 2024
11 checks passed
@mitchdenny mitchdenny deleted the mitchdenny/dockerfile.v0-buildargs-schema branch September 12, 2024 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aspire Schema missing Dockerfile buildArgs spec
2 participants