Skip to content

Commit

Permalink
Reverting 2 locks based on review feedback and early measurements
Browse files Browse the repository at this point in the history
  • Loading branch information
ladeak committed Aug 28, 2024
1 parent c4f92f7 commit 4cff31f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal sealed class InputFlowControl
private FlowControl _flow;
private int _pendingUpdateSize;
private bool _windowUpdatesDisabled;
private readonly Lock _flowLock = new();
private readonly object _flowLock = new();

public InputFlowControl(uint initialWindowSize, uint minWindowSizeIncrement)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ internal sealed class Http2FrameWriter
private bool _completed;
private bool _aborted;

private readonly Lock _windowUpdateLock = new();
private readonly object _windowUpdateLock = new();
private long _connectionWindow;
private readonly Queue<Http2OutputProducer> _waitingForMoreConnectionWindow = new();
// This is the stream that consumed the last set of connection window
Expand Down

0 comments on commit 4cff31f

Please sign in to comment.