Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Cleanups
  • Loading branch information
javiercn authored Jul 10, 2024
1 parent 5f6250f commit 5a5e9c5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/update-jquery-validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
title: [Templates][Identity] Update jquery-validation to ${{ env.JQUERY_VALIDATE_VERSION }}
body: |
Updates the jquery-validation scripts to ${{ env.JQUERY_VALIDATE_VERSION }}
# The branch name is based on the date in the format YYYY-MM-DD
branch: update-jquery-validate-to-${{ env.JQUERY_VALIDATE_VERSION }}
base: main
paths: |
Expand Down
7 changes: 2 additions & 5 deletions src/Mvc/build/copy-files.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ if (!repoRoot) {
throw new Error('RepoRoot environment variable is not set')
}

// Search all the folders in the src directory for the files "jquery.validate.js" and "jquery.validate.min.js" but skip this
// folder as well as the "node_modules" folder, the "bin" folder, and the "obj" folder. Recurse over subfolders.
// Search recursively over all the folders in the src directory for the files "jquery.validate.js" and "jquery.validate.min.js" except for node_modules, bin, and obj

const srcDir = path.join(repoRoot, 'src');
const files = [];
Expand All @@ -24,9 +23,7 @@ const search = (dir) => {

search(srcDir);

// Replace the files found with the versions from <<current-folder>>/node_modules/jquery-validation/dist.
// Note that <<current-folder>>/node_modules/jquery-validation/dist/jquery.validate.js needs to override the
// jquery.validate.js file found in the files array and the same for jquery.validate.min.js.
// Replace each found file with the file of the same name that we downloaded during install and that is located in node_modules/jquery-validation/dist/
const nodeModulesDir = path.join(import.meta.dirname, 'node_modules', 'jquery-validation', 'dist');

for (const file of files) {
Expand Down

0 comments on commit 5a5e9c5

Please sign in to comment.