Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] source-build: support building aspnetcore using non-portable runtime packages. #44978

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 9, 2022

Backport of #43937 to release/7.0

/cc @dougbu @tmds

source-build: support building aspnetcore using non-portable runtime packages.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

…packages.

Currently source-build performs 'runtime-portable' build that produces 'linux-{arch}'
packages that are used when building ASP.NET Core.

With this change, we can use the non-portable packages that are produced by the
source-build 'runtime' build, and eliminate the 'runtime-portable' build.
@github-actions github-actions bot requested review from a team, dougbu and wtgodbe as code owners November 9, 2022 18:31
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Nov 9, 2022
@ghost
Copy link

ghost commented Nov 9, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu dougbu enabled auto-merge (squash) November 9, 2022 19:23
- get logs for most CI jobs (not Code Check or Helix x64)
@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2022

Looks similar to #44741, we have a workaround for that in main. probably need to backport it, I'll open a PR

@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2022

#45001

@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu dougbu merged commit 33d20ad into release/7.0 Nov 10, 2022
@dougbu dougbu deleted the backport/pr-43937-to-release/7.0 branch November 10, 2022 21:02
@dougbu dougbu added this to the 7.0.1 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants