Update SDK to 8.0.100-rc.1.23374.2

[MackinnonBuck]

No description provided.

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[MackinnonBuck]

With this SDK update, we're seeing:

The PrivateSdkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative

Here's an example.

@ivanpovazan do you know what might have caused this?

[MackinnonBuck]

Also, the macOS runs are failing on restore, and that's happening in the efcore SDK update too. We can see if that gets resolved in the next SDK build.

[ivanpovazan]

Hi @MackinnonBuck, I am not sure why you started experiencing this issue by bumping the SDK version.
The reason why the error message appears:

The PrivateSdkAssemblies ItemGroup is required for _ComputeAssembliesToCompileToNative

is usually due to ResolvedILCompilerPack not being resolved properly during ResolveFrameworkReferences build target which should resolve the package directory and set PackageDirectory metadata on this item, which is later used in NativeAOT build integration targets to point to the sdk assemblies.

Why the package directory does not get resolved, I cannot tell for sure, but I would assume there is a problem with NuGet restore and/or version mismatch of ILCompiler packs.

Hope this helps

[wtgodbe]

@sbomer do you know of anything that might have changed related to @ivanpovazan's comment above?

[sbomer]

I'm investigating. This is the same issue as dotnet/runtime#89040 - I'll update there once I have an answer.

[RussKie]

@sbomer assigning to you for now.

[sbomer]

I believe this is no longer blocked on the issue mentioned in #49470 (comment).

[wtgodbe]

I think we're blocked on getting an SDK with dotnet/roslyn#69010

[wtgodbe]

That did the trick

[eerhardt]

Blazor WASM project templates tests are failing because of dotnet/sdk#34135. Need to wait for an SDK with the fix.

[amcasey]

Blazor WASM project templates tests are failing because of dotnet/sdk#34135. Need to wait for an SDK with the fix.

dotnet/sdk#34135 seems to cite dotnet/runtime#89273 as the problem and this comment seems to say that dotnet/sdk#34142 was a workaround. So I think we're waiting for dotnet/sdk#34142? Is that right, @eerhardt?

[javiercn]

@eerhardt this seems to be still stuck in the config source generator

[eerhardt]

@eerhardt this seems to be still stuck in the config source generator

We are still waiting on dotnet/sdk#34220 to be available in an official SDK build. I pushed the latest SDK from dotnet/installer, but it doesn't appear to have this fix.

[javiercn]

Still stuck error SYSLIB1104: Binding logic was not generated for a binder call. Unsupported input patterns include generic calls and passing boxed objects. [/private/tmp/helix/working/C0AC0A29/w/B0A309A6/e/Templates/BaseFolder/AspNet.ifxssxpdts2s/AspNet.ifxssxpdts2s.csproj

[eerhardt]

@javiercn - it looks like there are additional failures with the new SDK. Can you take a look?

Microsoft.AspNetCore.Components.E2ETest.Tests.ClientRenderingMultpleComponentsTest.CanRenderMultipleRootComponents

System.InvalidOperationException : Sequence contains no elements

   at System.Linq.ThrowHelper.ThrowNoElementsException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source)
   at Microsoft.AspNetCore.Components.E2ETest.Tests.ClientRenderingMultpleComponentsTest.<>c.<ReadMarkers>b__8_3(IGrouping`2 g) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ClientRenderingMultpleComponentsTest.cs:line 79
   at System.Linq.Enumerable.SelectEnumerableIterator`2.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Microsoft.AspNetCore.Components.E2ETest.Tests.ClientRenderingMultpleComponentsTest.ReadMarkers(String content) in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ClientRenderingMultpleComponentsTest.cs:line 79
   at Microsoft.AspNetCore.Components.E2ETest.Tests.ClientRenderingMultpleComponentsTest.CanRenderMultipleRootComponents() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ClientRenderingMultpleComponentsTest.cs:line 55
   at InvokeStub_ClientRenderingMultpleComponentsTest.CanRenderMultipleRootComponents(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

[javiercn]

@eerhardt yes. I was looking at them already

[eerhardt]

Still stuck error SYSLIB1104: Binding logic was not generated for a binder call. Unsupported input patterns include generic calls and passing boxed objects. [/private/tmp/helix/working/C0AC0A29/w/B0A309A6/e/Templates/BaseFolder/AspNet.ifxssxpdts2s/AspNet.ifxssxpdts2s.csproj

I've updated to the latest SDK which now has the fix. Let me know if you still see failures in this area.