Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow same version when updating versions in node packages #57921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow same version when updating versions in node packages #57921

wants to merge 1 commit into from

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 17, 2024

It's possible to end up with the package.json files for the node packages having the same version as the target version, typically if you cancel the build at just the right time and the package.json files end up edited. I think this can also happen if one of the node commands fails and leaves the backup files

@mmitche
Allow same version when updating versions in node packages
61ebb47 
It's possible to end up with the package.json files for the node packages having the same version as the target version, typically if you cancel the build at just the right time and the package.json files end up edited. I think this can also happen if one of the node commands fails and leaves the backup files
@mmitche mmitche requested review from wtgodbe and a team as code owners September 17, 2024 17:02
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

wtgodbe
wtgodbe approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @javiercn should confirm as well

This was referenced Sep 17, 2024
Open
Open
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 24, 2024
@mmitche
Copy link
Member Author

mmitche commented Sep 25, 2024

@javiercn Any concerns here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@javiercn javiercn javiercn approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmitche @javiercn @wtgodbe