Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Fix skip condition for IIS tests #57999

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[release/9.0] Fix skip condition for IIS tests #57999

merged 3 commits into from
Sep 23, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 20, 2024

These should be skipped on internal jobs as well

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Sep 20, 2024
@wtgodbe wtgodbe changed the base branch from release/9.0 to release/9.0-rc2 September 20, 2024 23:07
@wtgodbe wtgodbe requested a review from a team as a code owner September 20, 2024 23:07
@wtgodbe wtgodbe changed the base branch from release/9.0-rc2 to release/9.0 September 20, 2024 23:07
BrennanConroy
BrennanConroy reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspnetcore/src/Servers/IIS/IIS/test/Common.LongTests/StartupTests.cs

Line 1300 in 1d2deb0

[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
as well

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Sep 23, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 23, 2024

Failures unrelated

@wtgodbe wtgodbe merged commit 6bbc4f1 into release/9.0 Sep 23, 2024
21 of 25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/90skip branch September 23, 2024 15:50
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @BrennanConroy