Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine BidirectionalStream_MultipleStreamsOnConnection_ReusedFromPool #59979

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Quarantine BidirectionalStream_MultipleStreamsOnConnection_ReusedFromPool #59979

merged 1 commit into from
Jan 22, 2025

Conversation

SteveSandersonMS
Copy link
Member

See #59978

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jan 21, 2025
lewing
lewing approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reviewing/approving quarantine requests is there some guiding logic I should apply? Does aspnetcore also use the Known build error tooling, and if so, when?

@JamesNK
Copy link
Member

JamesNK commented Jan 22, 2025

Reviewing quarantine PR is just a rubber stamp. The person creating the PR has already created a nessessary issue to track it.

@lewing lewing merged commit 95bc200 into main Jan 22, 2025
27 checks passed
@lewing lewing deleted the stevesa/quarantine-59978 branch January 22, 2025 04:18
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing lewing approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveSandersonMS @JamesNK @lewing