Fix empty render of the ErrorBoundary #64526
Draft
+56
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix empty render of the ErrorBoundary
Description
This PR fixes a bug where ErrorBoundary renders empty content instead of ErrorContent when multiple child components throw errors in quick succession (e.g., errors thrown inside a foreach loop like in the test example).
How it works normally (single error):
The Renderer queues an empty render to clear the subtree, then calls
HandleException, which queues the ErrorContent render. This works correctly.The bug (multiple errors):
When a second error is thrown:
_hasPendingQueuedRender = trueHandleExceptionto queue the ErrorContent renderStateHasChanged()returns early because_hasPendingQueuedRenderis stilltruefrom step 1The queue ends up with:
[empty, ErrorContent, empty]instead of[empty, ErrorContent, empty, ErrorContent]. After the first ErrorContent renders, only the empty render remains in the queue, clearing the error UI.Solution:
After queuing the empty render but before calling
HandleException, manually reset_hasPendingQueuedRendertofalseusing the new internalHasPendingQueuedRenderproperty. This ensuresStateHasChanged()successfully queues the ErrorContent render for each error.Fixes #56950