Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VS for Mac properties from .NET 9 JSON fille #9425

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

richlander
Copy link
Member

@richlander richlander commented Jul 23, 2024

I assume that removing VS for Mac information is correct. We should change our tools for this generating this file.

@leecow @rbhanda

@richlander richlander changed the title Remove vs-mac-version property from .NET 9 Remove VS for Mac properties from .NET 9 JSON fille Jul 23, 2024
@richlander
Copy link
Member Author

Will this affect your use cases @mairaw?

@mairaw
Copy link
Contributor

mairaw commented Aug 15, 2024

I'd need to test this to see if this is a required/optional field.

@richlander
Copy link
Member Author

It would be good to remove use of it entirely from the website. There is no reason to display it.

@mairaw
Copy link
Contributor

mairaw commented Aug 15, 2024

Yep, it makes sense with the retirement of the product. But other people consume this file, so it would be good to check other potential impacts. I can stop reading and displaying this info at the website for sure. Not sure if we have a schema file for this @leecow

@richlander
Copy link
Member Author

Lee has an internal schema. I created a new one using .NET 9 APIs and my object model.

https://github.com/dotnet/core/pull/9427/files#diff-e735593946c18823b39b4ec6faf1c5936c357d36bec96dd04237cc1598e4797f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants