Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# 9.0 target-typed new #258

Merged
merged 3 commits into from
Jul 25, 2023
Merged

C# 9.0 target-typed new #258

merged 3 commits into from
Jul 25, 2023

Conversation

wise0704
Copy link
Contributor

@wise0704 wise0704 commented Jul 25, 2023

Target-typed new keyword is currently classified incorrectly as a method call.

Related #232, #239

@wise0704
Copy link
Contributor Author

@dotnet-policy-service agree

@JoeRobich
Copy link
Member

Thanks for this enhancement @wise0704! Would you be able to tests for this new behavior in constructor.tests.ts?

@wise0704
Copy link
Contributor Author

Sure, I'll try.

@wise0704
Copy link
Contributor Author

Thanks for this enhancement @wise0704! Would you be able to tests for this new behavior in constructor.tests.ts?

Seems like constructor.tests.ts is for constructor definitions. I added a test to the type-name.tests.ts instead as it seemed the most appropriate.

@JoeRobich
Copy link
Member

Thanks @wise0704!

@JoeRobich JoeRobich merged commit 993e384 into dotnet:main Jul 25, 2023
2 checks passed
@wise0704 wise0704 deleted the patch-1 branch July 25, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants