Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native-sized integer types #261

Merged
merged 2 commits into from
Jul 31, 2023
Merged

native-sized integer types #261

merged 2 commits into from
Jul 31, 2023

Conversation

wise0704
Copy link
Contributor

@JoeRobich
Copy link
Member

Thanks @wise0704! Could you add these to the PrimitiveTypes in the tokenize.ts and update an existing test or two to use them?

@wise0704
Copy link
Contributor Author

Didn't realise new keywords needed separate tokens. Added them now!

JoeRobich
JoeRobich approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wise0704!

@JoeRobich JoeRobich merged commit 7d29a39 into dotnet:main Jul 31, 2023
2 checks passed
@wise0704 wise0704 deleted the nint branch August 1, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wise0704 @JoeRobich