Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic method invocation #273

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix generic method invocation #273

merged 2 commits into from
Aug 9, 2023

Conversation

wise0704
Copy link
Contributor

@wise0704 wise0704 commented Aug 8, 2023

Before:
image

After:
image

Fixes #200

A better fix is to break down the patterns so not everything has to be in one line (similar to #77 (comment)), but for now at least this should fix the issue.

test/expressions.tests.ts Outdated Show resolved Hide resolved
@wise0704
Copy link
Contributor Author

wise0704 commented Aug 9, 2023

Interesting related article: 6.2.5 Grammar ambiguities, although the logic cannot be used with textmate grammar.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wise0704!

@JoeRobich JoeRobich merged commit 2759f6d into dotnet:main Aug 9, 2023
2 checks passed
@wise0704 wise0704 deleted the generic branch August 10, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The syntax highlighting is buggy with operator <<, >> and parentheses.
2 participants