Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for embedding install location options in apphost #318

Merged
merged 8 commits into from
Jul 2, 2024

Conversation

elinor-fung
Copy link
Member

There have been numerous requests around being able to customize how/where the .NET root path will be determined for a an application. This document describes a proposed mechanism for basic configuration of how apphost will search for the .NET install location.

This is intended to be a step towards a broader (not-yet-designed) SDK experience for building an application or set of applications with a customized .NET runtime path. It does not attempt to tackle the problem of the fuller experience.

cc @AaronRobinsonMSFT @richlander @TravisEz13 @dotnet/appmodel

@elinor-fung elinor-fung force-pushed the apphost-embed-install-location branch from 6edb392 to 7f421cc Compare June 24, 2024 15:53
@elinor-fung elinor-fung requested a review from vitek-karas July 1, 2024 05:37
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment:
(this might be there, but it's not super clear) If the app relative path is turned on, the apphost should only look there, it should not continue searching for global and/or registered runtimes.
Personally, I could see use cases for both where it does not search and also where it does, but the cases I've seen mostly seem to ask for the case where it doesn't search anymore (VS is a good example).
That said, allowing it to continue the search would make the apphost usable even without the runtime in the right place, so F5 and alike would work - but it could also make it look like everything is correct and the app breaks after deployment, which is not great either.

@elinor-fung
Copy link
Member Author

If the app relative path is turned on, the apphost should only look there, it should not continue searching for global and/or registered runtimes.

My intent was that it would only look there by default - but allow the search locations to be explicitly set to something like AppRelative;Global. So from the SDK side, if someone just sets AppRelativeDotNet, it will build an apphost that is set to only search app-relative and from the apphost side it searches based on whatever flags are set.

proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
proposed/apphost-embed-install-location.md Outdated Show resolved Hide resolved
Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@elinor-fung elinor-fung merged commit 62c393d into dotnet:main Jul 2, 2024
2 checks passed
@elinor-fung elinor-fung deleted the apphost-embed-install-location branch July 2, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants