Revert "fix: verify snapshot tests on CI build"

This reverts commit 35df8e9.
dotnet · Apr 7, 2024 · 464b947 · 464b947
1 parent f801d03
commit 464b947
Show file tree

Hide file tree

Showing 10 changed files with 7 additions and 17 deletions.
diff --git a/test/docfx.Snapshot.Tests/ModuleInitializer.cs b/test/docfx.Snapshot.Tests/ModuleInitializer.cs
@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Runtime.CompilerServices;
+using DiffEngine;
 
 namespace Docfx.Tests;
 
@@ -10,6 +11,7 @@ public static class ModuleInitializer
     [ModuleInitializer]
     public static void Initialize()
     {
+        BuildServerDetector.Detected = Environment.GetEnvironmentVariable("BUILD_SERVER") == "true";
         VerifyDiffPlex.Initialize(VerifyTests.DiffPlex.OutputType.Compact);
     }
 }
diff --git a/...hot.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.-ctor.html.view.verified.json b/...hot.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.-ctor.html.view.verified.json
@@ -128,7 +128,6 @@
           "platform": null,
           "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass__ctor.md&value=---%0Auid%3A%20MyExample.ExampleClass.%23ctor%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
           "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L13",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "implements": "",
@@ -360,7 +359,6 @@
   "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass__ctor_.md&value=---%0Auid%3A%20MyExample.ExampleClass.%23ctor*%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
   "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L13",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "syntax": "",

diff --git a/...t.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyEvent.html.view.verified.json b/...t.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyEvent.html.view.verified.json
@@ -293,7 +293,6 @@
   "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass_MyEvent.md&value=---%0Auid%3A%20MyExample.ExampleClass.MyEvent%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
   "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L7",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "implements": "",

diff --git a/....Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyMethod.html.view.verified.json b/....Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyMethod.html.view.verified.json
@@ -173,7 +173,6 @@
           "platform": null,
           "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass_MyMethod.md&value=---%0Auid%3A%20MyExample.ExampleClass.MyMethod%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
           "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L18",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "implements": "",
@@ -405,7 +404,6 @@
   "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass_MyMethod_.md&value=---%0Auid%3A%20MyExample.ExampleClass.MyMethod*%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
   "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L18",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "syntax": "",

diff --git a/...ests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyProperty.html.view.verified.json b/...ests/SamplesTest.Extensions/api/MyExample.ExampleClass.MyProperty.html.view.verified.json
@@ -175,7 +175,6 @@
           "platform": null,
           "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass_MyProperty.md&value=---%0Auid%3A%20MyExample.ExampleClass.MyProperty%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
           "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L11",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "implements": "",
@@ -407,7 +406,6 @@
   "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass_MyProperty_.md&value=---%0Auid%3A%20MyExample.ExampleClass.MyProperty*%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
   "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L11",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "syntax": "",

diff --git a/....Snapshot.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.html.view.verified.json b/....Snapshot.Tests/SamplesTest.Extensions/api/MyExample.ExampleClass.html.view.verified.json
@@ -106,7 +106,6 @@
           "isEii": false,
           "docurl": "",
           "sourceurl": "",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "syntax": "",
@@ -175,7 +174,6 @@
           "isEii": false,
           "docurl": "",
           "sourceurl": "",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "syntax": "",
@@ -244,7 +242,6 @@
           "isEii": false,
           "docurl": "",
           "sourceurl": "",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "syntax": "",
@@ -313,7 +310,6 @@
           "isEii": false,
           "docurl": "",
           "sourceurl": "",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "syntax": "",
@@ -955,7 +951,6 @@
   "docurl": "https://github.com/dotnet/docfx/new/main/apiSpec/new?filename=MyExample_ExampleClass.md&value=---%0Auid%3A%20MyExample.ExampleClass%0Asummary%3A%20'*You%20can%20override%20summary%20for%20the%20API%20here%20using%20*MARKDOWN*%20syntax'%0A---%0A%0A*Please%20type%20below%20more%20information%20about%20this%20API%3A*%0A%0A",
   "sourceurl": "https://github.com/dotnet/docfx/blob/main/samples/extensions/src/ExampleClass.cs/#L5",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "implements": "",

diff --git a/test/docfx.Snapshot.Tests/SamplesTest.Extensions/api/MyExample.html.view.verified.json b/test/docfx.Snapshot.Tests/SamplesTest.Extensions/api/MyExample.html.view.verified.json
@@ -59,7 +59,6 @@
           "isEii": false,
           "docurl": "",
           "sourceurl": "",
-          "description": "",
           "remarks": "",
           "conceptual": "",
           "syntax": "",
@@ -232,7 +231,6 @@
   "docurl": "",
   "sourceurl": "",
   "summary": "",
-  "description": "",
   "remarks": "",
   "conceptual": "",
   "syntax": "",

diff --git a/...ot.Tests/SamplesTest.SeedMarkdown/BuildFromProject.Class1.Issue8948.verified.md b/...ot.Tests/SamplesTest.SeedMarkdown/BuildFromProject.Class1.Issue8948.verified.md
@@ -30,7 +30,7 @@ public class Class1.Issue8948 : Class1.IIssue8948
 
 ### <a id="BuildFromProject_Class1_Issue8948_DoNothing__1"></a> DoNothing<T\>\(\)
 
-Does nothing with generic type <code class="typeparamref">T</code>.
+Does nothing with generic type T.
 
 ```csharp
 public void DoNothing<T>()

diff --git a/...fx.Snapshot.Tests/SamplesTest.SeedMarkdown/CatLibrary.ICatExtension.verified.md b/...fx.Snapshot.Tests/SamplesTest.SeedMarkdown/CatLibrary.ICatExtension.verified.md
@@ -4,7 +4,8 @@ Namespace: [CatLibrary](CatLibrary.md)
 Assembly: CatLibrary.dll  
 
 It's the class that contains ICat interface's extension method.
-<p>This class must be <b>public</b> and <b>static</b>.</p><p>Also it shouldn't be a geneic class</p>
+<p>This class must be <b>public</b> and <b>static</b>.</p>
+<p>Also it shouldn't be a geneic class</p>
 
 ```csharp
 public static class ICatExtension

diff --git a/test/docfx.Snapshot.Tests/SamplesTest.SeedMarkdown/CatLibrary.verified.md b/test/docfx.Snapshot.Tests/SamplesTest.SeedMarkdown/CatLibrary.verified.md
@@ -21,7 +21,8 @@
  [ICatExtension](CatLibrary.ICatExtension.md)
 
 It's the class that contains ICat interface's extension method.
-<p>This class must be <b>public</b> and <b>static</b>.</p><p>Also it shouldn't be a geneic class</p>
+<p>This class must be <b>public</b> and <b>static</b>.</p>
+<p>Also it shouldn't be a geneic class</p>
 
  [Tom](CatLibrary.Tom.md)