-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: search improvements #10113
base: main
Are you sure you want to change the base?
feat!: search improvements #10113
Conversation
Hello |
I'm done on my side (with some minor tweaks that could be done, see TODO). I will push a merge against current |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10113 +/- ##
==========================================
+ Coverage 74.31% 79.36% +5.04%
==========================================
Files 536 548 +12
Lines 23189 23686 +497
Branches 4056 4079 +23
==========================================
+ Hits 17234 18799 +1565
+ Misses 4853 3713 -1140
- Partials 1102 1174 +72 ☔ View full report in Codecov by Sentry. |
Motivation
DocFX's current state of the search functionality has some flaws:
ManagedReferenceExample
and I search forManaged
I will get no results. Same goes forManagedReference
What has changed
_searchIndexUseMetadata
and_searchIndexUseMetadataTitle
to opt-inFillMetadata
Title
andSummary
inManifestProperties
summary
SearchIndexItem.Keywords
holds different content for MREFsManagedReferenceExample
->Managed ManagedReference ManagedReferenceExample ManagedExample Reference ReferenceExample Example
Keywords
is still present and it's used to store exclusively for keywords, and processed by the search engineSummary
is rendered by the themes (brief)Notes / TODO