Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 24, 2025

This PR intended to superseded PR #10829.

When @typescript-eslint packages are updated to latest version.
It cause Cannot redefine plugin "@typescript-eslint" error.

This PR contains following changes.

@filzrev filzrev force-pushed the deps-update-typescript-eslint branch from 3a5218a to d463be9 Compare November 11, 2025 02:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @typescript-eslint packages from version 8.44.1 to 8.46.2 and fixes the "Cannot redefine plugin '@typescript-eslint'" error by reusing the TypeScript ESLint plugin exported by the neostandard package instead of importing it directly.

Key Changes

  • Updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version 8.46.2
  • Modified ESLint configuration to reference the TypeScript ESLint plugin from neostandard's exported plugins
  • Removed direct import of @typescript-eslint/eslint-plugin from eslint.config.js

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
templates/package.json Updated versions of @typescript-eslint packages from 8.44.1 to 8.46.2
templates/package-lock.json Updated dependency tree reflecting version 8.46.2 for all @typescript-eslint packages and their transitive dependencies
templates/eslint.config.js Removed direct import of @typescript-eslint/eslint-plugin and now references the plugin from neostandard.plugins to avoid plugin redefinition
Files not reviewed (1)
  • templates/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import {defineConfig, globalIgnores} from 'eslint/config'
import js from '@eslint/js'
import tsesLint from 'typescript-eslint'
import tsesLintParser from '@typescript-eslint/parser'
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parser is still being imported directly from @typescript-eslint/parser, but the plugin is now sourced from neostandard. For consistency and to avoid potential version mismatches or plugin conflicts, consider also using the parser from neostandard if it's exported, similar to how the plugin is now being accessed via neostandard.plugins['typescript-eslint'].plugin.

Copilot uses AI. Check for mistakes.
@yufeih
Copy link
Contributor

yufeih commented Dec 19, 2025

@copilot open a new pull request to apply changes based on this PR, don't change impl but update package.lock.json so we don't have merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants