Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove options from MarkdigExtensionSetting #9830

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Apr 1, 2024

Some minor tweak to #9820

  1. Simplify config by removing the options property
  2. Change emoji config from bool to an enum
{
  "markdigExtensions": [
    "FootNotes",
    {"Emojis": "default"},
    {"AutoIdentifiers": "default"},
    {"MediaLinks": {"width": 800, "height": 400}}
  ]
}

cc @filzrev

@filzrev
Copy link
Contributor

filzrev commented Apr 1, 2024

Thanks for updates.
I think this PR has made the config simpler and easier to understand.

Additionally, it might be possible to support a remove' default extension with a remove' parameter in the future.
(Discussed at #7833)

@yufeih yufeih merged commit c0cc51e into main Apr 1, 2024
7 checks passed
@yufeih yufeih deleted the mdext-simplfy branch April 1, 2024 07:35
@yufeih
Copy link
Contributor Author

yufeih commented Apr 1, 2024

Additionally, it might be possible to support a remove' default extension with a remove' parameter in the future.
(Discussed at #7833)

That can be perhaps be configured as { "extensionName": false }

p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants