-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add InternalVisibleTo
attribute for benchmark project
#9840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9840 +/- ##
==========================================
+ Coverage 74.31% 78.97% +4.65%
==========================================
Files 536 538 +2
Lines 23189 23319 +130
Branches 4056 4049 -7
==========================================
+ Hits 17234 18417 +1183
+ Misses 4853 3774 -1079
- Partials 1102 1128 +26 ☔ View full report in Codecov by Sentry. |
Is there a reason why we need to publish to NuGet first before adding the benchmark project? |
It's because I want to write benchmarks that targeting following two versions in single benchmark.
Note: And it's also can be used to compare multiple NuGet versions benchmark.(Example) |
Make sense |
…t#9840) chore: add InternalVisibleTo attribute for benchmark project
…t#9840) chore: add InternalVisibleTo attribute for benchmark project
This PR add
InternalsVisibleTo
attribute for benchmark projects.I'll planning to add benchmark project to
benchmarks/Docfx.Benchmarks
in separated PR.after this PR content is published to NuGet.
Previous PR discussion about
InternalsVisibleTo
attributes#9652