Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add InternalVisibleTo attribute for benchmark project #9840

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Apr 6, 2024

This PR add InternalsVisibleTo attribute for benchmark projects.

I'll planning to add benchmark project to benchmarks/Docfx.Benchmarks in separated PR.
after this PR content is published to NuGet.

Previous PR discussion about InternalsVisibleTo attributes
#9652

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (fe673ec) to head (82ed632).
Report is 111 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9840      +/-   ##
==========================================
+ Coverage   74.31%   78.97%   +4.65%     
==========================================
  Files         536      538       +2     
  Lines       23189    23319     +130     
  Branches     4056     4049       -7     
==========================================
+ Hits        17234    18417    +1183     
+ Misses       4853     3774    -1079     
- Partials     1102     1128      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih
Copy link
Contributor

yufeih commented Apr 12, 2024

Is there a reason why we need to publish to NuGet first before adding the benchmark project?

@filzrev
Copy link
Contributor Author

filzrev commented Apr 12, 2024

Is there a reason why we need to publish to NuGet first before adding the benchmark project?

It's because I want to write benchmarks that targeting following two versions in single benchmark.

  1. NuGet published version (Baseline)
  2. Local source build version

Note:
It's not tested yet, that it can referencing same assemblies with different versions aliases (by referencing using extern alias).
If it's not possible. It need to switch two version by using csproj settings.

And it's also can be used to compare multiple NuGet versions benchmark.(Example)

@yufeih
Copy link
Contributor

yufeih commented Apr 14, 2024

Make sense

@yufeih yufeih merged commit 59b4261 into dotnet:main Apr 14, 2024
7 checks passed
filzrev added a commit to filzrev/docfx that referenced this pull request Apr 14, 2024
…t#9840)

chore: add InternalVisibleTo attribute for benchmark project
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
…t#9840)

chore: add InternalVisibleTo attribute for benchmark project
@filzrev filzrev deleted the chore-add-project-for-benchmarks branch July 12, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants