Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine 3.21 images #6097

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Add Alpine 3.21 images #6097

merged 9 commits into from
Dec 9, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell commented Dec 6, 2024

Fixes #6095

@lbussell lbussell marked this pull request as ready for review December 6, 2024 19:23
@lbussell lbussell requested a review from a team as a code owner December 6, 2024 19:23
@lbussell lbussell requested review from ellahathaway and removed request for a team December 6, 2024 19:23
@lbussell
Copy link
Contributor Author

lbussell commented Dec 6, 2024

I had to make some adjustments to Alpine tests:

  • Improved error messages so they're more actionable
  • Made it so that the floating tag can be on a specific version instead of always the latest. This is in manifest.versions.json.

Here's an example of the error you get when you make a mistake now:

Microsoft.DotNet.Docker.Tests.StaticTagTests.FloatingAlpineTag_OnLatestVersion (97ms): Error Message: 
      Expected tags to contain a single item matching ^8.0(-preview)?-alpine$.IsMatch(tag) because image DockerfileInfo { Repo = runtime-deps, MajorMinor = 8.0, Os = alpine3.20, Architecture = amd64 } should have an alpine floating tag, but no such item was found.
      Expected tags to contain a single item matching ^8.0(-preview)?-alpine$.IsMatch(tag) because image DockerfileInfo { Repo = runtime-deps, MajorMinor = 8.0, Os = alpine3.20, Architecture = arm32v7 } should have an alpine floating tag, but no such item was found.
      Expected tags to contain a single item matching ^8.0(-preview)?-alpine$.IsMatch(tag) because image DockerfileInfo { Repo = runtime-deps, MajorMinor = 8.0, Os = alpine3.20, Architecture = arm64v8 } should have an alpine floating tag, but no such item was found.

manifest.versions.json Outdated Show resolved Hide resolved
@lbussell lbussell requested review from mthalman and MichaelSimons and removed request for MichaelSimons December 9, 2024 16:46
@lbussell lbussell merged commit bee318b into dotnet:nightly Dec 9, 2024
98 checks passed
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants