-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Replace Deprecated BeginImageContextWithOptions with UIGraphicsImageRenderer #18631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Converting to draft, the Essentials Screenshot API doesn't work yet |
Hum I was going to swear I did this already somewhere |
This causes some tests to be flaky, not sure how or why... |
Any news with this? It's some months iOS 17 is out, I'm having the issue for a new implementation but I need to know if something is going to happen at a certain time... or I'll just have to take another way |
Thanks @jfversluis for creating this draft-PR. I also started to face issues on iOS 17.4
The crash of the app occurs when entering the background on iOS. I tried to merge main to this branch, however, I don't have permissions, so I can test the latest changes. Can somebody give me a hand, please? |
e0ebea1
to
ed24f1a
Compare
@vhugogarcia rebased! Is this something you're looking into as well? I'd gladly take some help! |
Hello @jfversluis , I am also looking for an update on this, since I am also facing the issue on my apps. I'm not expert on this topic, I'm totally new. I will try to see what I can do to help to solve the failed tests, maybe we need to update them somehow. Just a guess, hehehe! |
Oh yeah don't worry was just wondering! 😄 maybe you knew something about it! |
Ah man this is so close! I can't find this discussed anywhere else really so I'll just rabble here 😁 |
👀 |
@jfversluis any word on getting this in? ... this is causing some serious issues in production. Is there any way to work around this? |
This one got stale and I think some calls already got replaced, moving the rest to this updated one: #28682 |
Description of Change
In iOS 17 the
UIGraphics.BeginImageContextWithOptions
API is deprecated and we're using that in a couple of places. This change replaces those with the new thing that we should be using.Issues Fixed
Related xamarin/Xamarin.Forms#15833 & xamarin/Xamarin.Forms#15827