Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed layout is back (maybe?) #24758

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Sep 13, 2024

Description of Change

In Xamarin using CompressedLayout.IsHeadless="True" literally changed the performance of our app from "laggy" to "snappy" on Android :)

This is just a proof-of-concept to show how compressed layout support could look like in MAUI and if adding such support would increase the performance or not.

Test case First render BindingContext changes Clear
iOS main 1316ms 166.2ms 46.4ms
iOS PR 1225ms 118.4ms 123.8ms
Android main 533ms 55.4ms 34.6ms
Android PR 433ms 50.2ms 30.2ms

I still don't understand the reason behind slow Clear on iOS, especially because that PlatformView.ClearSubviews() didn't change.

Also, I've not implemented the InvalidateMeasure part, on which I feel there would be additional considerations.

Anyway, before going further with this one, I wanted to double-check with you if this will ever be taken in consideration.

Simulator Screen Recording - iPhone Xs - 2024-09-13 at 18 18 17

@albyrock87 albyrock87 requested a review from a team as a code owner September 13, 2024 16:14
Copy link
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 13, 2024
@albyrock87 albyrock87 marked this pull request as draft September 13, 2024 16:15
@tj-devel709 tj-devel709 added platform/android 🤖 platform/iOS 🍎 area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels Sep 16, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter community ✨ Community Contribution platform/android 🤖 platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants